Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-2552] Change default sort on search page to relevance #3698

Merged

Conversation

jeremycharron
Copy link
Contributor

@jeremycharron jeremycharron commented Feb 10, 2022

Description

Change sort on search results to relevancy / Best Match by default
"Position" is removed as a sort option on the search results page
Category pages still default to listing products by position

Related Issue

Closes PWA-2552

Closes PWA-2572

Acceptance

Verification Stakeholders

Project maintainers

Specification

Verification Steps

Products on search results are sorted by relevancy / "Best Match" by default
"Position" is removed as a sort option on the search results page
Category pages still default to listing products by position

Test scenario(s) for direct fix/feature

  1. Execute a search
  2. Verify that products are sorted by "Best Match"
  3. Verify that "Position" is not an option in the Sort dropdown
  4. Navigate to a category page
  5. Verify that products are sorted by "Position" by default
  6. Execute another search
  7. Ensure the page loads successfully and that products are sorted by "Best Match"
  8. Execute search which list categories in filters like search for "Tops Dress"

Test scenario(s) for any existing impacted features/areas

  1. Verify that new and existing Jest tests pass
  2. Verify that Cypress test passes

Test scenario(s) for any Magento Backend Supported Configurations

N/A

Is Browser/Device testing needed?

I don't think it's required, but nice to have.

Any ad-hoc/edge case scenarios that need to be considered?

No

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

No breaking change

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jeremycharron jeremycharron added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 10, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 10, 2022

Messages
📖

Associated JIRA tickets: PWA-2552.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6cd127e

michaelyu0123
michaelyu0123 previously approved these changes Feb 11, 2022
Copy link
Contributor

@michaelyu0123 michaelyu0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelyu0123
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 11, 2022

Successfully started codebuild job for cypress

@michaelyu0123
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 11, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 11, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 11, 2022

Successfully started codebuild job for cypress

@dpatil-magento dpatil-magento merged commit c667189 into develop Feb 11, 2022
@dpatil-magento dpatil-magento deleted the jcharron/PWA-2552-change-sort-on-search-page-to-relevance branch February 11, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants